<div dir="ltr">Hello,<div><br></div><div>So I took a look firstly on the code which builds the running configuration. It seems to crash in "build_config_global" (cfgbuild.c:281) when calling the switch API function "igmp_get". Now, if we look at this function, it receives as parameters the sw_ops structure, a buffer to be filled with information and a pointer to an integer variable where it will return if IGMP snooping is activated. At the above mentioned line the second parameter is NULL (the buffer). I believe that the purpose of this piece of code is to determine whether IGMP is on or off.</div>
<div>The "linux" implementation does not check the buffer parameter and it crashes when it tries to copy a bitmap to the buffer. Should I change the "igmp_get" function to be able to receive NULL as a second parameter and to check only if IGMP is on or off?</div>
<div><br></div><div>Regards</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Sep 25, 2013 at 3:25 PM, Radu Rendec <span dir="ltr"><<a href="mailto:radu.rendec@mindbit.ro" target="_blank">radu.rendec@mindbit.ro</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Just to make it clear for everybody: we don't focus on *blaming* people<br>
for the bugs, we focus just on fixing the bugs :)<br>
<br>
Chances are higher that the person who worked on a specific module fixes<br>
the bugs faster, though.<br>
<br>
The thing is that we want to promote LiSA and what Brezular wants to do<br>
is a good opportunity. This is pretty much why I would like to give him<br>
a working version that he can put in his distro.<br>
<br>
Thx,<br>
<br>
Radu<br>
<div class="HOEnZb"><div class="h5"><br>
On Wed, 2013-09-25 at 14:47 +0300, Claudiu Ghioc wrote:<br>
> Hello,<br>
><br>
><br>
> So I think I'm the one to blame. I'll have a look tonight at the code<br>
> and I'll try to build and run it again.<br>
><br>
><br>
> Regards<br>
><br>
><br>
> On Wed, Sep 25, 2013 at 2:35 PM, Radu Rendec <<a href="mailto:radu.rendec@mindbit.ro">radu.rendec@mindbit.ro</a>><br>
> wrote:<br>
> On Tue, 2013-09-24 at 19:02 +0300, Andreea-Cristina Hodea<br>
> wrote:<br>
> > On Tue, Sep 24, 2013 at 5:55 PM, Radu Rendec<br>
> <<a href="mailto:radu.rendec@mindbit.ro">radu.rendec@mindbit.ro</a>> wrote:<br>
> > > [root@bat cli]# ./swcli<br>
> > > <a href="http://bat.mindbit.ro#sh" target="_blank">bat.mindbit.ro#sh</a> run<br>
> > > Segmentation fault<br>
> > > [root@bat cli]# Building configuration...<br>
> > ><br>
> > ><br>
> > > <a href="http://bat.mindbit.ro" target="_blank">bat.mindbit.ro</a>(config)#int netdev dummy0<br>
> > > Command rejected: ioctl() failed (0 - Success)<br>
> > > <a href="http://bat.mindbit.ro" target="_blank">bat.mindbit.ro</a>(config)#int netdev dummy1<br>
> > > Command rejected: ioctl() failed (0 - Success)<br>
> > ><br>
> > > This is behavior is consistent with centos6 as well. Any<br>
> ideas?<br>
> > ><br>
> ><br>
> > Did you try the with 'lisa' back-end or with 'linux'<br>
> back-end? I don't<br>
> > know if it helps but I think I ran into the same issue with<br>
> 'lisa'<br>
> > back-end when I had forgotten to insert the switch.ko<br>
> module. After<br>
> > inserting the current switch.ko everything worked for me.<br>
><br>
><br>
> I tried with the 'linux' back-end. The bridges for the<br>
> "default" vlans<br>
> get created, so I'm pretty sure I got it compiled correctly.<br>
><br>
> The guy who integrated LiSA with GNS3 now wants to integrate<br>
> LiSA with<br>
> Core Linux. He wrote me on my private address, but I'll add<br>
> the devel<br>
> list in the loop. We agreed that we should use the devel<br>
> version of<br>
> LiSA, because it doesn't require any kernel patch.<br>
><br>
> Thanks,<br>
><br>
> Radu<br>
><br>
><br>
> _______________________________________________<br>
> LiSA-Devel mailing list<br>
> <a href="mailto:LiSA-Devel@lisa.mindbit.ro">LiSA-Devel@lisa.mindbit.ro</a><br>
> <a href="http://lisa.mindbit.ro/mailman/listinfo/lisa-devel" target="_blank">http://lisa.mindbit.ro/mailman/listinfo/lisa-devel</a><br>
><br>
><br>
><br>
><br>
><br>
> --<br>
> Claudiu Ghioc<br>
> Software Developer<br>
> Email: <a href="mailto:claudiu.ghioc@gmail.com">claudiu.ghioc@gmail.com</a><br>
> <a href="tel:%2B%2840%29%20745%20783%20796" value="+40745783796">+(40) 745 783 796</a><br>
> _______________________________________________<br>
> LiSA-Devel mailing list<br>
> <a href="mailto:LiSA-Devel@lisa.mindbit.ro">LiSA-Devel@lisa.mindbit.ro</a><br>
> <a href="http://lisa.mindbit.ro/mailman/listinfo/lisa-devel" target="_blank">http://lisa.mindbit.ro/mailman/listinfo/lisa-devel</a><br>
<br>
<br>
_______________________________________________<br>
LiSA-Devel mailing list<br>
<a href="mailto:LiSA-Devel@lisa.mindbit.ro">LiSA-Devel@lisa.mindbit.ro</a><br>
<a href="http://lisa.mindbit.ro/mailman/listinfo/lisa-devel" target="_blank">http://lisa.mindbit.ro/mailman/listinfo/lisa-devel</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Claudiu Ghioc<div>Software Developer<br>Email: <a href="mailto:claudiu.ghioc@gmail.com" target="_blank">claudiu.ghioc@gmail.com</a><br>
+(40) 745 783 796</div></div>
</div>