<div dir="ltr">I didn't manage to get the answer to the interface problem. Though I tested adding interfaces from "swctl" and it worked, so I think it's something from the CLI. It also works for Ethernet interfaces configured from CLI (e.g. interface Ethernet 3).<div>
<br></div><div>I will change the igmp_get function for the "linux" back-end to check the second parameter.</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Sep 26, 2013 at 2:24 PM, Radu Rendec <span dir="ltr"><<a href="mailto:radu.rendec@mindbit.ro" target="_blank">radu.rendec@mindbit.ro</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Thu, 2013-09-26 at 14:06 +0300, Claudiu Ghioc wrote:<br>
<br>
> So I took a look firstly on the code which builds the running<br>
> configuration. It seems to crash in<br>
> "build_config_global" (cfgbuild.c:281) when calling the switch API<br>
> function "igmp_get". Now, if we look at this function, it receives as<br>
> parameters the sw_ops structure, a buffer to be filled with<br>
> information and a pointer to an integer variable where it will return<br>
> if IGMP snooping is activated. At the above mentioned line the second<br>
> parameter is NULL (the buffer). I believe that the purpose of this<br>
> piece of code is to determine whether IGMP is on or off.<br>
> The "linux" implementation does not check the buffer parameter and it<br>
> crashes when it tries to copy a bitmap to the buffer. Should I change<br>
> the "igmp_get" function to be able to receive NULL as a second<br>
> parameter and to check only if IGMP is on or off?<br>
<br>
</div>I've just looked at the "lisa" backend implementation. It copies the 2nd<br>
parameter directly into the kenrel argument structure, so basically it<br>
hands over the problem to the kernel code. The kernel code does check if<br>
the argument is NULL.<br>
<br>
So just to keep the API consistent across all backend implementations,<br>
the function should be modified to check for NULL as well.<br>
<br>
What about the other issue (not being able to add new interfaces into<br>
the switch)?<br>
<div class="HOEnZb"><div class="h5"><br>
Thanks,<br>
<br>
Radu<br>
<br>
<br>
<br>
_______________________________________________<br>
LiSA-Devel mailing list<br>
<a href="mailto:LiSA-Devel@lisa.mindbit.ro">LiSA-Devel@lisa.mindbit.ro</a><br>
<a href="http://lisa.mindbit.ro/mailman/listinfo/lisa-devel" target="_blank">http://lisa.mindbit.ro/mailman/listinfo/lisa-devel</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Claudiu Ghioc<div>Software Developer<br>Email: <a href="mailto:claudiu.ghioc@gmail.com" target="_blank">claudiu.ghioc@gmail.com</a><br>
+(40) 745 783 796</div></div>
</div>