[LiSA-Devel] Stability of latest master branch

[Claudiu Ghioc]

Hello,

So I took a look firstly on the code which builds the running
configuration. It seems to crash in "build_config_global" (cfgbuild.c:281)
when calling the switch API function "igmp_get". Now, if we look at this
function, it receives as parameters the sw_ops structure, a buffer to be
filled with information and a pointer to an integer variable where it will
return if IGMP snooping is activated. At the above mentioned line the
second parameter is NULL (the buffer). I believe that the purpose of this
piece of code is to determine whether IGMP is on or off.
The "linux" implementation does not check the buffer parameter and it
crashes when it tries to copy a bitmap to the buffer. Should I change the
"igmp_get" function to be able to receive NULL as a second parameter and to
check only if IGMP is on or off?

Regards


On Wed, Sep 25, 2013 at 3:25 PM, Radu Rendec <radu.rendec at mindbit.ro> wrote:

> Just to make it clear for everybody: we don't focus on *blaming* people
> for the bugs, we focus just on fixing the bugs :)
>
> Chances are higher that the person who worked on a specific module fixes
> the bugs faster, though.
>
> The thing is that we want to promote LiSA and what Brezular wants to do
> is a good opportunity. This is pretty much why I would like to give him
> a working version that he can put in his distro.
>
> Thx,
>
> Radu
>
> On Wed, 2013-09-25 at 14:47 +0300, Claudiu Ghioc wrote:
> > Hello,
> >
> >
> > So I think I'm the one to blame. I'll have a look tonight at the code
> > and I'll try to build and run it again.
> >
> >
> > Regards
> >
> >
> > On Wed, Sep 25, 2013 at 2:35 PM, Radu Rendec <radu.rendec at mindbit.ro>
> > wrote:
> >         On Tue, 2013-09-24 at 19:02 +0300, Andreea-Cristina Hodea
> >         wrote:
> >         > On Tue, Sep 24, 2013 at 5:55 PM, Radu Rendec
> >         <radu.rendec at mindbit.ro> wrote:
> >         > > [root at bat cli]# ./swcli
> >         > > bat.mindbit.ro#sh run
> >         > > Segmentation fault
> >         > > [root at bat cli]# Building configuration...
> >         > >
> >         > >
> >         > > bat.mindbit.ro(config)#int netdev dummy0
> >         > > Command rejected: ioctl() failed (0 - Success)
> >         > > bat.mindbit.ro(config)#int netdev dummy1
> >         > > Command rejected: ioctl() failed (0 - Success)
> >         > >
> >         > > This is behavior is consistent with centos6 as well. Any
> >         ideas?
> >         > >
> >         >
> >         > Did you try the with 'lisa' back-end or with 'linux'
> >         back-end? I don't
> >         > know if it helps but I think I ran into the same issue with
> >         'lisa'
> >         > back-end when I had forgotten to insert the switch.ko
> >         module. After
> >         > inserting the current switch.ko everything worked for me.
> >
> >
> >         I tried with the 'linux' back-end. The bridges for the
> >         "default" vlans
> >         get created, so I'm pretty sure I got it compiled correctly.
> >
> >         The guy who integrated LiSA with GNS3 now wants to integrate
> >         LiSA with
> >         Core Linux. He wrote me on my private address, but I'll add
> >         the devel
> >         list in the loop. We agreed that we should use the devel
> >         version of
> >         LiSA, because it doesn't require any kernel patch.
> >
> >         Thanks,
> >
> >         Radu
> >
> >
> >         _______________________________________________
> >         LiSA-Devel mailing list
> >         LiSA-Devel at lisa.mindbit.ro
> >         http://lisa.mindbit.ro/mailman/listinfo/lisa-devel
> >
> >
> >
> >
> >
> > --
> > Claudiu Ghioc
> > Software Developer
> > Email: claudiu.ghioc at gmail.com
> > +(40) 745 783 796
> > _______________________________________________
> > LiSA-Devel mailing list
> > LiSA-Devel at lisa.mindbit.ro
> > http://lisa.mindbit.ro/mailman/listinfo/lisa-devel
>
>
> _______________________________________________
> LiSA-Devel mailing list
> LiSA-Devel at lisa.mindbit.ro
> http://lisa.mindbit.ro/mailman/listinfo/lisa-devel
>



-- 
Claudiu Ghioc
Software Developer
Email: claudiu.ghioc at gmail.com
+(40) 745 783 796
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lisa.mindbit.ro/pipermail/lisa-devel/attachments/20130926/4ab7720f/attachment.html